linux-kernel - Re: [PATCH V2 1/4] soc: amlogic: use name instead of index as criterion

Open Source and information security mailing list archives

Date:   Wed, 19 Jul 2023 22:44:13 +0300
From:   Dmitry Rokosov <ddrokosov@...rdevices.ru>
To:     Xianwei Zhao <xianwei.zhao@...ogic.com>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>
Subject: Re: [PATCH V2 1/4] soc: amlogic: use name instead of index as
 criterion

On Fri, Jul 07, 2023 at 08:37:07AM +0800, Xianwei Zhao wrote:
> The  variate 'index' could be equal to zero in some SoCs. Such as C3 SoC,
> PWRC_C3_NNA_ID be defined zero. Use 'name' instead of 'index' as criterion.
> 
> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>

Reviewed-by: Dmitry Rokosov <ddrokosov@...rdevices.ru>

> ---
> V1 -> V2: add a new patch for change.
> ---
>  drivers/soc/amlogic/meson-secure-pwrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c
> index 25b4b71df9b8..c11d65a3e3d9 100644
> --- a/drivers/soc/amlogic/meson-secure-pwrc.c
> +++ b/drivers/soc/amlogic/meson-secure-pwrc.c
> @@ -179,7 +179,7 @@ static int meson_secure_pwrc_probe(struct platform_device *pdev)
>  	for (i = 0 ; i < match->count ; ++i) {
>  		struct meson_secure_pwrc_domain *dom = &pwrc->domains[i];
>  
> -		if (!match->domains[i].index)
> +		if (!match->domains[i].name)
>  			continue;
>  
>  		dom->pwrc = pwrc;
> -- 
> 2.37.1
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

-- 
Thank you,
Dmitry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives