linux-kernel - RE: [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and Retimer Cable type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR11MB0048115794666D99182D85DBA939A@MWHPR11MB0048.namprd11.prod.outlook.com>
Date:   Wed, 19 Jul 2023 20:46:05 +0000
From:   "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "pmalani@...omium.org" <pmalani@...omium.org>,
        "bleung@...omium.org" <bleung@...omium.org>
Subject: RE: [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and
 Retimer Cable type

Hi Greg,

Thank you for the review and feedback. 

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Tuesday, July 18, 2023 6:29 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org;
> heikki.krogerus@...ux.intel.com; pmalani@...omium.org;
> bleung@...omium.org
> Subject: Re: [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and
> Retimer Cable type
> 
> On Mon, Jul 17, 2023 at 07:47:03PM -0700, Utkarsh Patel wrote:
> > Cable type such as active and retimer received as a part of
> > Thunderbolt3 or Thunderbolt4 cable discover mode VDO needs to be
> > configured in the thunderbolt alternate mode.
> >
> > Configuring the register bits for this cable type is changed with
> > Intel Meteor Lake platform. BIT2 for Retimer/Redriver cable and BIT22
> > for Active/Passive cable.
> >
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@...el.com>
> > ---
> > Changes in v4:
> >  - No changes.
> >
> > Changes in v3:
> >  - No changes.
> >
> > Changes in v2:
> >  - No changes.
> > ---
> > ---
> >  drivers/usb/typec/mux/intel_pmc_mux.c | 28
> > +++++++++++++++++++++++----
> >  1 file changed, 24 insertions(+), 4 deletions(-)
> 
> Why the 2 --- lines?

This is by mistake.

> 
> And why are you not cc:ing all the proper people (i.e. the person that can
> actually apply this...)?
> 
Ack.

I will correct both of these when I send next patch. 

Sincerely,
Utkarsh Patel.