linux-kernel - Re: [PATCH v2] power: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Jul 2023 22:51:31 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Simon Glass <sjg@...omium.org>
Cc:     Rob Herring <robh@...nel.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Support Opensource <support.opensource@...semi.com>,
        David Lechner <david@...hnology.com>,
        Iskren Chernev <me@...ren.info>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Matheus Castello <matheus@...tello.eng.br>,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-oxnas@...ups.io
Subject: Re: [PATCH v2] power: Explicitly include correct DT includes

Hi,

On Tue, Jul 18, 2023 at 07:08:01PM -0600, Simon Glass wrote:
> On Tue, 18 Jul 2023 at 08:31, Rob Herring <robh@...nel.org> wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> >
> > Acked-by: David Lechner <david@...hnology.com>
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> > v2:
> > - Fix double include of of.h
> > ---
> >  drivers/power/reset/as3722-poweroff.c            | 1 -
> >  drivers/power/reset/brcm-kona-reset.c            | 4 ++--
> >  drivers/power/reset/gpio-poweroff.c              | 3 ++-
> >  drivers/power/reset/gpio-restart.c               | 2 +-
> >  drivers/power/reset/keystone-reset.c             | 3 ++-
> >  drivers/power/reset/ocelot-reset.c               | 4 ++--
> >  drivers/power/reset/odroid-go-ultra-poweroff.c   | 3 ++-
> >  drivers/power/reset/oxnas-restart.c              | 2 --
> >  drivers/power/reset/st-poweroff.c                | 2 +-
> >  drivers/power/reset/syscon-poweroff.c            | 3 +--
> >  drivers/power/reset/syscon-reboot.c              | 3 +--
> >  drivers/power/reset/xgene-reboot.c               | 2 +-
> >  drivers/power/supply/axp20x_ac_power.c           | 1 -
> >  drivers/power/supply/axp20x_battery.c            | 1 -
> >  drivers/power/supply/axp20x_usb_power.c          | 1 -
> >  drivers/power/supply/cpcap-battery.c             | 2 +-
> >  drivers/power/supply/da9150-charger.c            | 2 --
> >  drivers/power/supply/da9150-fg.c                 | 1 -
> >  drivers/power/supply/lego_ev3_battery.c          | 2 +-
> >  drivers/power/supply/ltc2941-battery-gauge.c     | 2 +-
> >  drivers/power/supply/ltc4162-l-charger.c         | 2 +-
> >  drivers/power/supply/max14656_charger_detector.c | 2 +-
> >  drivers/power/supply/max17040_battery.c          | 2 +-
> >  drivers/power/supply/max8903_charger.c           | 1 -
> >  drivers/power/supply/rn5t618_power.c             | 1 -
> >  drivers/power/supply/rt5033_charger.c            | 2 +-
> >  drivers/power/supply/rt9455_charger.c            | 3 +--
> >  drivers/power/supply/sbs-battery.c               | 2 +-
> >  drivers/power/supply/tps65090-charger.c          | 2 +-
> >  drivers/power/supply/tps65217_charger.c          | 1 -
> >  drivers/power/supply/twl4030_charger.c           | 1 +
> >  31 files changed, 26 insertions(+), 37 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg@...omium.org>

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)