linux-kernel - Re: [PATCH] staging: rtl8192e: Rename variable bCurrentHTSupport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLdZNNs/NlbWAFCP@basil>
Date:   Tue, 18 Jul 2023 20:32:04 -0700
From:   Tree Davies <tdavies@...kphysics.net>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     gregkh@...uxfoundation.org, dan.carpenter@...aro.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Rename variable bCurrentHTSupport

On Tue, Jul 18, 2023 at 09:56:24PM +0200, Philipp Hortmann wrote:
> On 7/15/23 22:14, Tree Davies wrote:
> > Philipp,
> > 
> > I think I understand what I did wrong. Each of these original patches were
> > created/based from the same commit hash. So it makes sense that only the
> > first one applied would apply cleanly and the others would fail.
> > 
> > My apologies,
> > Tree
> 
> Hi Tree,
> 
> you could work this way if you ensure that each patch does not modify code
> (and some lines above and below) a previous patch modified. But it is not a
> good way to do so. Existing tools assume that you create your commits onto
> each other and then make patches out of them.
> 
> Another issue right now is that approximately 18 patches send in and are
> possibly applied (for rtl8192e). Your patches need to fit onto those
> patches. Otherwise they cannot be applied and will be rejected.
> 
> Typically Greg applies all patches once a week. But it seems that he has a
> bunch of other more urgent tasks. So you need to focus on other kernel
> related task like educate yourself or prepare patches without sending them
> in.
> 
> Thanks for your support.
> 
> Bye Philipp
> 

Thnaks Philipp,

No worries, I'm patient, and happy to help any way I can. 
I have hardware coming in the mail this week! I already have  
3 mPCIe rtl8192e devices, but I am waiting on the PCIe adapter card for
my test machine.

I'm stoked. :)
Tree