linux-kernel - Re: [PATCH v3 1/9] video/aperture: Add a helper to detect if an aperture contains firmware FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <184a570c-cd11-fc08-be63-3ff795dfc6d8@loongson.cn>
Date:   Thu, 20 Jul 2023 05:18:41 +0800
From:   suijingfeng <suijingfeng@...ngson.cn>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Sui Jingfeng <sui.jingfeng@...ux.dev>
Cc:     David Airlie <airlied@...il.com>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        intel-gfx@...ts.freedesktop.org, kvm@...r.kernel.org,
        linux-fbdev@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Helge Deller <deller@....de>
Subject: Re: [PATCH v3 1/9] video/aperture: Add a helper to detect if an
 aperture contains firmware FB

Hi,


On 2023/7/20 04:43, Bjorn Helgaas wrote:
> On Wed, Jul 12, 2023 at 12:43:02AM +0800, Sui Jingfeng wrote:
>> From: Sui Jingfeng <suijingfeng@...ngson.cn>
>>
>> This patch adds the aperture_contain_firmware_fb() function to do the
>> determination. Unfortunately, due to the fact that the apertures list
>> will be freed dynamically, the location and size information of the
>> firmware FB will be lost after dedicated drivers call
>> aperture_remove_conflicting_devices(),
>> aperture_remove_conflicting_pci_devices() or
>> aperture_remove_all_conflicting_devices() functions
>> We solve this problem by introducing two static variables that record the
>> firmware framebuffer's start addrness and end addrness. It assumes that the
>> system has only one active firmware framebuffer driver at a time. We don't
>> use the global structure screen_info here, because PCI resources may get
>> reallocated (the VRAM BAR could be moved) during the kernel boot stage.
> s/addrness/address/ (twice)


Will be fixed at the next version, thanks.