linux-kernel - Re: [PATCH] fs: export emergency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 21:08:06 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Bill O'Donnell <billodo@...hat.com>
Cc:     Rob Barnes <robbarnes@...gle.com>, bleung@...omium.org,
        linux-fsdevel@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: export emergency_sync

On Tue, Jul 18, 2023 at 05:13:06PM -0500, Bill O'Donnell wrote:
> On Tue, Jul 18, 2023 at 09:45:40PM +0000, Rob Barnes wrote:
> > emergency_sync forces a filesystem sync in emergency situations.
> > Export this function so it can be used by modules.
> > 
> > Signed-off-by: Rob Barnes <robbarnes@...gle.com>
> 
> Example of an emergency situation?

An example from existing code in
drivers/firmware/arm_scmi/scmi_power_control.c:

static inline void
scmi_request_forceful_transition(struct scmi_syspower_conf *sc)
{
        dev_dbg(sc->dev, "Serving forceful request:%d\n",
                sc->required_transition);

#ifndef MODULE
        emergency_sync();
#endif

Arguably emergency_sync() should also be called if the file is built
as module.

Either case, I think it would make sense to add an example to the commit
description.

Thanks,
Guenter