linux-kernel - Re: [PATCH] m68k/pci: Drop useless pcibios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c657304-7fb6-1f03-9fa6-7225fc14c28d@kernel.org>
Date:   Wed, 19 Jul 2023 14:37:09 +1000
From:   Greg Ungerer <gerg@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-m68k@...ts.linux-m68k.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] m68k/pci: Drop useless pcibios_setup()

Hi Bjorn,

On 19/7/23 06:42, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The PCI core supplies a weak pcibios_setup() implementation that is
> identical to the m68k implementation.  Remove the m68k version since it is
> unnecessary.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Thanks. Seeing as this is related to the ColdFire parts I'll take this through
the m68knommu git tree. Applied to the for-next branch.

Regards
Greg


> ---
>   arch/m68k/kernel/pcibios.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
> index b0e110d3d2e6..9504eb19d73a 100644
> --- a/arch/m68k/kernel/pcibios.c
> +++ b/arch/m68k/kernel/pcibios.c
> @@ -92,9 +92,3 @@ void pcibios_fixup_bus(struct pci_bus *bus)
>   		pci_write_config_byte(dev, PCI_LATENCY_TIMER, 32);
>   	}
>   }
> -
> -char *pcibios_setup(char *str)
> -{
> -	return str;
> -}
> -