[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6faf3d1d-f05f-4d28-82d9-32c8e22fd29b@linaro.org>
Date: Wed, 19 Jul 2023 08:15:00 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Nikunj Kela <quic_nkela@...cinc.com>, sudeep.holla@....com
Cc: cristian.marussi@....com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport
On 18/07/2023 23:16, Nikunj Kela wrote:
>
> On 7/18/2023 11:42 AM, Krzysztof Kozlowski wrote:
>> On 18/07/2023 20:25, Nikunj Kela wrote:
>>>>> +
>>>>> + scmi_info = devm_kzalloc(dev, sizeof(*scmi_info), GFP_KERNEL);
>>>>> + if (!scmi_info)
>>>>> + return -ENOMEM;
>>>>> +
>>>>> + np = of_parse_phandle(cdev->of_node, "shmem", 0);
>>>>> + if (!of_device_is_compatible(np, "arm,scmi-shmem"))
>>>> You leak here reference.
>>> Wouldn't the devm_* API take care of that implicitly? It is same in
>>> smc.c as well.
>> Thanks for bringing my attention to this. I sent a fix for smc.c. Fix
>> your patch as well, please.
> Thanks, I thought you were referring to kzalloc cleanup. Will include
> this fix. BTW, you may need to fix mailbox.c as well.
Indeed, thanks.
Best regards,
Krzysztof
Powered by blists - more mailing lists