linux-kernel - Re: [RESEND PATCH 2/2] Input: mms114

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLeBIma/CLcK++RF@google.com>
Date:   Tue, 18 Jul 2023 23:22:26 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Artur Weber <aweber.kernel@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [RESEND PATCH 2/2] Input: mms114 - add support for touch keys

On Fri, Jul 14, 2023 at 12:04:24PM +0200, Artur Weber wrote:
> +	} else if (data->num_keycodes > MMS114_MAX_TOUCHKEYS) {
> +		dev_warn(&client->dev,
> +			"Found %d linux,keycodes but max is %zd, ignoring the rest\n",
> +			 data->num_keycodes, MMS114_MAX_TOUCHKEYS);

This gives me the following warning:

drivers/input/touchscreen/mms114.c: In function ‘mms114_probe’:
drivers/input/touchscreen/mms114.c:520:25: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=]
  520 |                         "Found %d linux,keycodes but max is %zd, ignoring the rest\n",
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I changed the format specifier to "%d" and applied.

Thanks.

-- 
Dmitry