linux-kernel - Re: [PATCH v2] staging: r8712: Fix memory leak in _r8712_init_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLeI+b3oXP3hstdg@nam-dell>
Date:   Wed, 19 Jul 2023 08:55:53 +0200
From:   Nam Cao <namcaov@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        syzbot+cf71097ffb6755df8251@...kaller.appspotmail.com,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] staging: r8712: Fix memory leak in
 _r8712_init_xmit_priv()

On Fri, Jul 14, 2023 at 12:54:17PM -0500, Larry Finger wrote:
> In the above mentioned routine, memory is allocated in several places.
> If the first succeeds and a later one fails, the routine will leak memory.
> This patch fixes commit 2865d42c78a9 ("staging: r8712u: Add the new driver
> to the mainline kernel"). A potential memory leak in
> r8712_xmit_resource_alloc() is also addressed.
> 
> Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
> Reported-by: syzbot+cf71097ffb6755df8251@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/x/log.txt?x=11ac3fa0a80000
> Cc: stable@...r.kernel.org
> Cc: Nam Cao <namcaov@...il.com>
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>

I am not qualified to make comments on the code style, but it looks functionally
correct to me. So:

Reviewed-by: Nam Cao <namcaov@...il.com>

Best regards,
Nam