linux-kernel - Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver default on platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230719092019.5545ee15@md1za8fc.ad001.siemens.net>
Date:   Wed, 19 Jul 2023 09:20:19 +0200
From:   Henning Schild <henning.schild@...mens.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Lee Jones <lee@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        linux-watchdog@...r.kernel.org, Pavel Machek <pavel@....cz>,
        Mark Gross <markgross@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Tobias Schaffner <tobias.schaffner@...mens.com>
Subject: Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver
 default on platform

Am Tue, 18 Jul 2023 08:07:52 -0700
schrieb Guenter Roeck <linux@...ck-us.net>:

> On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote:
> > If a user did choose to enable Siemens Simatic platform support they
> > likely want that driver to be enabled without having to flip more
> > config switches. So we make the watchdog driver config switch
> > default to the platform driver switches value.
> > 
> > Signed-off-by: Henning Schild <henning.schild@...mens.com>
> > ---
> >  drivers/watchdog/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index ee97d89dfc11..ccdbd1109a32 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -1681,6 +1681,7 @@ config NIC7018_WDT
> >  config SIEMENS_SIMATIC_IPC_WDT
> >  	tristate "Siemens Simatic IPC Watchdog"
> >  	depends on SIEMENS_SIMATIC_IPC
> > +	default SIEMENS_SIMATIC_IPC  
> 
> Why not just "default y" ? That does the same (it will be set to m if
> SIEMENS_SIMATIC_IPC=m) without the complexity.

I see. Thanks! In that case i will go for "default y" and not "default
m" which i wrote about in the other mail.

Henning

> Guenter
> 
> >  	select WATCHDOG_CORE
> >  	select P2SB
> >  	help
> > -- 
> > 2.41.0
> >