linux-kernel - Re: [PATCH net v4] net: lan966x: fix parameter check in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230718175238.226810e3@kernel.org>
Date:   Tue, 18 Jul 2023 17:52:38 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Minjie Du <duminjie@...o.com>
Cc:     Horatiu Vultur <horatiu.vultur@...rochip.com>,
        UNGLinuxDriver@...rochip.com (maintainer:MICROCHIP LAN966X ETHERNET
        DRIVER), "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Richard Cochran <richardcochran@...il.com>,
        netdev@...r.kernel.org (open list:MICROCHIP LAN966X ETHERNET DRIVER),
        linux-kernel@...r.kernel.org (open list),
        opensource.kernel@...o.com,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net v4] net: lan966x: fix parameter check in two
 functions

On Mon, 17 Jul 2023 10:22:35 +0800 Minjie Du wrote:
>  	vrule = vcap_get_rule(lan966x->vcap_ctrl, rule_id);
> -	if (vrule) {
> +	if (!IS_ERR_OR_NULL(vrule)) {

Please make vcap_get_rule() return an error pointer rather than NULL.
Mixing the two is a common source of errors.
-- 
pw-bot: cr