linux-kernel - [PATCH v3] selftests/input: add tests for the EVIOCSCLOCKID ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230719083003.1562415-1-delfassy@redhat.com>
Date:   Wed, 19 Jul 2023 11:30:03 +0300
From:   Dana Elfassy <delfassy@...hat.com>
To:     shuah@...nel.org, usama.anjum@...labora.com, eballetbo@...nel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Dana Elfassy <dangel101@...il.com>,
        Dana Elfassy <delfassy@...hat.com>,
        Enric Balletbo Serra <eballetbo@...il.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: [PATCH v3] selftests/input: add tests for the EVIOCSCLOCKID ioctl

From: Dana Elfassy <dangel101@...il.com>

This patch introduces tests for the EVIOCSCLOCKID ioctl, for full
coverage of the different clkids

Signed-off-by: Dana Elfassy <delfassy@...hat.com>
Reviewed-by: Enric Balletbo Serra <eballetbo@...il.com>
Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
---
Changes in v3:
- Modified signed-off-by email
- Added Reviewed-by tag

Changes in v2:
- Replaced clkids numerical values with their equivalent definition

This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
[1] https://patchwork.kernel.org/project/linux-input/patch/20230607153214.15933-1-eballetbo@kernel.org/

 tools/testing/selftests/input/evioc-test.c | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tools/testing/selftests/input/evioc-test.c b/tools/testing/selftests/input/evioc-test.c
index ad7b93fe39cf..83ce1a3c9b84 100644
--- a/tools/testing/selftests/input/evioc-test.c
+++ b/tools/testing/selftests/input/evioc-test.c
@@ -17,6 +17,7 @@
 #include <sys/stat.h>
 #include <time.h>
 #include <unistd.h>
+#include <linux/time.h>
 
 #include "../kselftest_harness.h"
 
@@ -234,4 +235,33 @@ TEST(eviocsrep_set_repeat_settings)
 	selftest_uinput_destroy(uidev);
 }
 
+TEST(eviocsclockid_set_clockid)
+{
+	struct selftest_uinput *uidev;
+	int clkid = CLOCK_REALTIME;
+	int rc;
+
+	rc = selftest_uinput_create_device(&uidev, -1);
+	ASSERT_EQ(0, rc);
+	ASSERT_NE(NULL, uidev);
+
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	clkid = CLOCK_MONOTONIC;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	clkid = CLOCK_BOOTTIME;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	// case default
+	clkid = -1;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(-1, rc);
+
+	selftest_uinput_destroy(uidev);
+}
+
 TEST_HARNESS_MAIN
-- 
2.41.0