linux-kernel - Re: [PATCH v7 5/5] mfd: tps6586x: register restart handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230719084449.GH1082701@google.com>
Date:   Wed, 19 Jul 2023 09:44:49 +0100
From:   Lee Jones <lee@...nel.org>
To:     Benjamin Bara <bbara93@...il.com>
Cc:     dmitry.osipenko@...labora.com, konstantin@...uxfoundation.org,
        benjamin.bara@...data.com, jonathanh@...dia.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, peterz@...radead.org,
        rafael.j.wysocki@...el.com, richard.leitner@...ux.dev,
        treding@...dia.com, wsa+renesas@...g-engineering.com,
        wsa@...nel.org
Subject: Re: [PATCH v7 5/5] mfd: tps6586x: register restart handler

On Wed, 19 Jul 2023, Benjamin Bara wrote:

> Hi Dmitry,
> 
> thanks for the feedback!
> 
> On Tue, 18 Jul 2023 at 06:46, Dmitry Osipenko <dmitry.osipenko@...labora.com> wrote:
> > 15.07.2023 10:53, Benjamin Bara пишет:
> > >
> > > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> > > Acked-for-MFD-by: Lee Jones <lee@...nel.org>
> >
> > Acked-for-MFD-by isn't a valid tag, scripts/checkpatch.pl should tell
> > you about it.
> >
> > In general you may add a comment to a tag, like this:
> >
> >   Acked-by: Lee Jones <lee@...nel.org> # for MFD
> >
> > In this particular case, the comment is unnecessary because Lee is the
> > MFD maintainer, hence his ack itself implies the MFD subsys.
> 
> I saw the warning, but Lee requested to add it like this [1].
> 
> @Konstantin:
> Do you think it makes sense to print a warning when adding "non-standard
> trailers" during running "b4 trailers -u", maybe around the
> find_trailers() checks? I could provide a RFC, if considered useful.
> [1] https://lore.kernel.org/all/20230518094434.GD404509@google.com/

Dmitry, Benjamin,

The warning is valid.  The patch will not be applied like this.

I will remove it when I merge the patch.

-- 
Lee Jones [李琼斯]