linux-kernel - Re: [PATCH v2 4/4] arm64: dts: freescale: Add DEBIX SOM A and SOM A I/O Board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230719091834.amfmakhwcp6562wu@pengutronix.de>
Date:   Wed, 19 Jul 2023 11:18:34 +0200
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, laurent.pinchart@...asonboard.com,
        dan.scally@...asonboard.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] arm64: dts: freescale: Add DEBIX SOM A and SOM A
 I/O Board support

Hi Shawn,

On 23-07-19, Shawn Guo wrote:
> On Mon, Jul 17, 2023 at 06:51:27PM +0200, Marco Felsch wrote:

...

> > +	reg_baseboard_vdd3v3: regulator-baseboard-vdd3v3 {
> > +		compatible = "regulator-fixed";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		regulator-name = "BB_VDD3V3";
> > +		gpio = <&expander0 10 GPIO_ACTIVE_HIGH>;
> > +		/* Required timings for ethernet phy's */
> > +		startup-delay-us = <50000>;
> > +		off-on-delay-us = <110000>;
> > +		enable-active-high;
> 
> Can we place this right after the line below?
> 
>   gpio = <&expander0 10 GPIO_ACTIVE_HIGH>;

Sure.

> > +		regulator-always-on;
> > +	};

...

> > +&i2c4 {
> > +	expander0: gpio@20 {
> > +		compatible = "nxp,pca9535";
> > +		reg = <0x20>;
> > +		gpio-controller;
> > +		#gpio-cells = <0x02>;
> > +	};
> > +
> > +	expander1: gpio@23 {
> > +		compatible = "nxp,pca9535";
> > +		reg = <0x23>;
> > +		gpio-controller;
> > +		#gpio-cells = <0x02>;
> > +
> > +		/*
> > +		 * Since USB1 is bound to peripheral mode we need to ensure
> > +		 * that VBUS is turned off.
> > +		 */
> > +		usb30-otg-hog {
> > +			gpio-hog;
> > +			gpios = <13 GPIO_ACTIVE_HIGH>;
> > +			output-low;
> > +			line-name = "USB30_OTG_EN";
> > +		};
> > +	};
> > +
> > +	eeprom@52 {
> > +		compatible = "atmel,24c02";
> > +		reg = <0x52>;
> > +		pagesize = <16>;
> > +	};
> > +
> > +	rtc@51 {
> 
> Sort them in order of unit-address.

Of course, thanks.

> > +		compatible = "haoyu,hym8563";
> > +		reg = <0x51>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_rtc>;
> > +		interrupt-parent = <&gpio4>;
> > +		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> > +		#clock-cells = <0>;
> > +	};
> > +};

> > +&i2c4 {
> > +	clock-frequency = <400000>;
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_i2c4>;
> > +	status = "okay";
> > +
> > +	adc@48 {
> > +		 compatible = "ti,ads1115";
> > +		 reg = <0x48>;
> > +
> 
> Unnecessary newline.

Dropped it, thanks.

> > +		 #address-cells = <1>;
> > +		 #size-cells = <0>;
> > +
> > +		 channel@4 {
> > +			 reg = <4>;
> > +			 ti,gain = <1>;
> > +			 ti,datarate = <7>;
> > +		 };
> 
> Have a newline between nodes.

Sure.

Regards,
  Marco