[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <319ee5f7-2dbd-430d-8ab1-a7b072ac7a9f@kadam.mountain>
Date: Wed, 19 Jul 2023 12:44:29 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Shenwei Wang <shenwei.wang@....com>,
Arnd Bergmann <arnd@...db.de>,
Andy Shevchenko <andy@...nel.org>, Marek Vasut <marex@...x.de>,
Marc Zyngier <maz@...nel.org>,
Dan Carpenter <error27@...il.com>, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: mxc: fix unused function warnings
On Tue, Jul 18, 2023 at 09:39:08PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The new runtime PM support causes a harmless warning about
> unused functions when runtime PM is disabled:
>
> drivers/gpio/gpio-mxc.c:612:12: error: 'mxc_gpio_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/gpio/gpio-mxc.c:602:12: error: 'mxc_gpio_runtime_suspend' defined but not used [-Werror=unused-function]
>
> Change the driver to use the more modern helper macros that avoid these
> warnings, and remove the now unnecessary __maybe_unused annotations
>
> Fixes: 3283d820dce64 ("gpio: mxc: add runtime pm support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
The patch is nice, but I don't understand why __maybe_unused doesn't
work?
regards,
dan carpenter
Powered by blists - more mailing lists