linux-kernel - Re: [PATCH 1/2] dt-bindings: add vendor-prefixes and bindings for pcd8544 displays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7915f04f-9eb2-78a0-edb4-1db179bfd18e@linaro.org>
Date:   Wed, 19 Jul 2023 11:50:10 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Viktar Simanenka <viteosen@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: add vendor-prefixes and bindings for
 pcd8544 displays

On 19/07/2023 11:29, Viktar Simanenka wrote:
> On 2023-07-18 08:35, Krzysztof Kozlowski wrote:
>> Bindings are always separate patches.
>> Please run scripts/checkpatch.pl and fix reported warnings.
> 
> Added vendor-prefix to fix warning.
> 
>>> + inverted:
>>> +    maxItems: 1
>>> +    description: Invert display colors
>> You described the desired Linux feature or behavior, not the actual
>> hardware. The bindings are about the latter, so instead you need to
>> rephrase the property and its description to match actual hardware
>> capabilities/features/configuration etc.
> 
> revised the descriptions and added suitable types according to the
> documentation
> 
>> Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
> 
> cleaned up unneccessary fields (leftovers) from tested binding
> 
> On 2023-07-18 9:19, Rob Herring wrote:
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date
>> Please check and re-submit after running the above command yourself.
> 
> upgraded dtschema and found all the warnings. thanks. seems to be fixed
> 
> Signed-off-by: Viktar Simanenka <viteosen@...il.com>

No clue what is this - is it a reply or new patch to review... does not
look like the latter, so I will just skip it. Please version your
patches, provide changelog and send proper patchsets.

Best regards,
Krzysztof