linux-kernel - Re: [PATCH v3] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9c1b702d-fdee-b7c0-9e79-4822f0d2340b@kernel.org>
Date:   Wed, 19 Jul 2023 19:14:33 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     杜敏杰 <duminjie@...o.com>,
        Viresh Kumar <vireshk@...nel.org>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        "open list:LIBATA PATA ARASAN COMPACT FLASH CONTROLLER" 
        <linux-ide@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Cc:     "opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: [PATCH v3] ata: pata_arasan_cf: Use dev_err_probe() instead
 dev_err() in data_xfer()

On 7/19/23 19:03, 杜敏杰 wrote:
> It is possible for dma_request_chan() to return EPROBE_DEFER, which means
> acdev->host->dev is not ready yet.
> At this point dev_err() will have no output.
> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
> V1 - V3:
> Fix code format.
> ---
>  drivers/ata/pata_arasan_cf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 6ab294322..c85932c20 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
>  	/* dma_request_channel may sleep, so calling from process context */
>  	acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
>  	if (IS_ERR(acdev->dma_chan)) {
> -		dev_err(acdev->host->dev, "Unable to get dma_chan\n");
> +		dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
> +						"Unable to get dma_chan\n")

Seriously ? You keep resending the same. Still not aligned. And even
worse: this will not even compile as this is missing ";".

Please improve your process and (1) act on comments and (2) properly
test your changes.


>  		acdev->dma_chan = NULL;
>  		goto chan_request_fail;
>  	}

-- 
Damien Le Moal
Western Digital Research