linux-kernel - RE: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922FBECED98089BB36841668639A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Wed, 19 Jul 2023 10:18:30 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Thierry Reding <thierry.reding@...il.com>
CC:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Randy Dunlap <rd.dunlab@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>
Subject: RE: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors


> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Sent: Wednesday, July 19, 2023 11:14 AM
> To: Thierry Reding <thierry.reding@...il.com>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>; Randy Dunlap
> <rd.dunlab@...il.com>; linux-kernel@...r.kernel.org; linux-
> pwm@...r.kernel.org; Biju Das <biju.das.jz@...renesas.com>
> Subject: Re: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
> 
> Hello,
> 
> On Wed, Jul 19, 2023 at 09:40:22AM +0200, Thierry Reding wrote:
> > On Tue, Jul 18, 2023 at 06:57:16PM +0200, Uwe Kleine-König wrote:
> > > On Tue, Jul 18, 2023 at 03:24:58PM +0200, Thierry Reding wrote:
> > > > Honestly, do we really need all of this complexity? I have
> > > > specific configurations to test all of the PWM drivers to make
> sure they build.
> > > > There's probably edge cases that don't get tested, but sooner or
> > > > later I expect some build bot will encounter those and then we can
> > > > rectify things. But in many cases that I've seen COMPILE_TEST just
> > > > happens to do more harm than good.
> > >
> > > Without COMPILE_TEST you'd need to build at least for the following
> > > archs to build all pwm drivers:
> > >
> > > 	armv4+5
> > > 	armv7
> > > 	armv7m
> > > 	arm64
> > > 	mips
> > > 	riscv
> > > 	shmobile
> >
> > This one is actually ARCH_RENESAS and is armv7.
> 
> Oh indeed. ARCH_RENESAS exists for both arm and shmobile. TIL

arm64 and risc-v too. This MTU3 driver should work on RISC-V(RZ/Five) as well(need to test at some point).

Cheers,
Biju

> 
> > > 	x86
> >
> > But yeah, those are the platforms that I build for. It's not terribly
> > complicated to do since all of the above have publicly available
> > cross- compilers that are easy to install. Also, most of the time I do
> > incremental builds, so these are quite quick.
> >
> > > I personally like COMPILE_TEST as it reduces the number of needed
> > > test builds to 1 (I think).
> >
> > Anyway, I wasn't arguing that we should get rid of COMPILE_TEST
> > altogether, just that for cases like this it doesn't seem worth the
> > extra complexity. RZ_MTU3 is an MFD and already || COMPILE_TEST, so we
> > can easily always enable it.
> 
> Ah, I got that wrong then. I can life with this one.
> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 | https://www.pengutronix.de/
> |