linux-kernel - Re: [PATCH v1] spi: Use dev_err_probe instead of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a7f2c3b2-2caa-4e96-b7ec-02f8566797c6@sirena.org.uk>
Date:   Wed, 19 Jul 2023 13:38:06 +0100
From:   Mark Brown <broonie@...nel.org>
To:     王明-软件底层技术部 
        <machel@...o.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-rpi-kernel@...ts.infradead.org" 
        <linux-rpi-kernel@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] spi: Use dev_err_probe instead of dev_err

On Wed, Jul 19, 2023 at 05:37:02AM +0000, 王明-软件底层技术部 wrote:

> +		ret = dev_err_probe(dev, PTR_ERR(ctlr->dma_tx),
> +							"no tx-dma configuration found - not using dma mode\n");

The indentation on the second line here is badly messed up, it's
indented far too much.  Same for the rx channel.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)