linux-kernel - Re: [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in dspi_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <dd60d083-6ffe-4d74-8c5b-588a62303b34@sirena.org.uk>
Date:   Wed, 19 Jul 2023 13:42:50 +0100
From:   Mark Brown <broonie@...nel.org>
To:     杜敏杰 <duminjie@...o.com>
Cc:     Vladimir Oltean <olteanv@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        "open list:FREESCALE DSPI DRIVER" <linux-spi@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:PTP HARDWARE CLOCK SUPPORT" <netdev@...r.kernel.org>,
        "opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in
 dspi_request_dma()

On Wed, Jul 19, 2023 at 07:13:02AM +0000, 杜敏杰 wrote:

> -		dev_err(dev, "rx dma channel not available\n");
> -		ret = PTR_ERR(dma->chan_rx);
> -		return ret;
> +		return dev_err_probe(dev, PTR_ERR(dma->chan_rx),
> +							"rx dma channel not available\n");

The indentation on the second line is messed up here, it's far too
indented.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)