linux-kernel - Re: [PATCH] gpio: loongson1 :remove unneeded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vf2ZyOU2Vz8qGjnCmXb5FkuBnA3VM1fGOc0FhEQEv9C8Q@mail.gmail.com>
Date:   Wed, 19 Jul 2023 16:05:53 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Keguang Zhang <keguang.zhang@...il.com>
Cc:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-mips@...r.kernel.org, andy@...nel.org, brgl@...ev.pl,
        linus.walleij@...aro.org, Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: loongson1 :remove unneeded platform_set_drvdata()call

On Wed, Jul 19, 2023 at 3:30 PM Keguang Zhang <keguang.zhang@...il.com> wrote:
>
> On Wed, Jul 19, 2023 at 6:14 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
> >
> > In the drivers/gpio/gpio-loongson1 the call to platform_set_drvdata was
> > removed.
> > This function call was found to be unnecesarry as the associated

unnecessary

> > structure is defined inside the local .c file.
> > It doesn't use any type of function either so it can be removed without
> > any complications.
>
> If there is a ls1x_gpio_remove(), platform_get_drvdata() will be called.
> Then platform_set_drvdata() will be necessary.

I don't get this. Is it just a side note? To me the patch looks legit.

...

With typo fixed,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>


-- 
With Best Regards,
Andy Shevchenko