linux-kernel - Re: [PATCH v2 1/4] fs/9p: remove unnecessary and overrestrictive check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5578264.lUQuLdSRdS@silver>
Date:   Wed, 19 Jul 2023 15:18:33 +0200
From:   Christian Schoenebeck <linux_oss@...debyte.com>
To:     Latchesar Ionkov <lucho@...kov.net>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Eric Van Hensbergen <ericvh@...nel.org>
Cc:     v9fs@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, Robert Schwebel <r.schwebel@...gutronix.de>,
        Eric Van Hensbergen <ericvh@...nel.org>
Subject: Re: [PATCH v2 1/4] fs/9p: remove unnecessary and overrestrictive check

On Tuesday, July 18, 2023 10:50:15 PM CEST Eric Van Hensbergen wrote:
> This eliminates a check for shared that was overrestrictive and
> duplicated a check in generic_file_readonly_mmap.
> 
> Reviewed-by: Dominique Martinet <asmadeus@...ewreck.org>
> Reviewed-by: Christian Schoenebeck <linux_oss@...debyte.com>
> Signed-off-by: Eric Van Hensbergen <ericvh@...nel.org>
> ---
>  fs/9p/vfs_file.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 2996fb00387fa..bda3abd6646b8 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -506,8 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma)
>  
>  	if (!(v9ses->cache & CACHE_WRITEBACK)) {
>  		p9_debug(P9_DEBUG_CACHE, "(no mmap mode)");

"(r/o mmap mode)" ?

> -		if (vma->vm_flags & VM_MAYSHARE)
> -			return -ENODEV;
>  		invalidate_inode_pages2(filp->f_mapping);
>  		return generic_file_readonly_mmap(filp, vma);
>  	}
> 
>