linux-kernel - Re: [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <660f59ed-b936-1667-c7ab-ba21bac60836@lwfinger.net>
Date:   Wed, 19 Jul 2023 08:25:17 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     hanyu001@...suo.com, pkshih@...ltek.com, kvalo@...nel.org
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar"

On 7/19/23 04:54, hanyu001@...suo.com wrote:
> 
> This patch fixes the checkpatch.pl error:
> 
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar" 
> should be "foo *bar"
> 
> Signed-off-by: Yu Han <hanyu001@...suo.com>
> ---
>   drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c 
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index d18c092..27b029b 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct 
> ieee80211_hw *hw, u8 channel)
>   }
> 
>   static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw,
> -                       u32 *targetchnl, u32 * curvecount_val,
> +                       u32 *targetchnl, u32 *curvecount_val,
>                          bool is5g, u32 *curveindex)
>   {
>       struct rtl_priv *rtlpriv = rtl_priv(hw);

The preferred subject would be "wifi: rtlwifi: rtl8192de: ...." That can 
probably be fixed at merge time. I will let Kalle decide that part.

Reviewed-by: Larry Finger<Larry.Finger@...inger.net>

Thanks,

Larry