linux-kernel - Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230719141111.ykg2pfv4dmyvutqm@CAB-WSD-L081021>
Date:   Wed, 19 Jul 2023 17:11:11 +0300
From:   Dmitry Rokosov <ddrokosov@...rdevices.ru>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     zelong dong <zelong.dong@...ogic.com>, <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Kevin Hilman <khilman@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <kelvin.zhang@...ogic.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT
 bindings for Amlogic C3 Reset Controller

On Wed, Jul 19, 2023 at 02:33:03PM +0200, Krzysztof Kozlowski wrote:
> On 19/07/2023 13:50, Dmitry Rokosov wrote:
> > On Wed, Jul 19, 2023 at 02:09:52PM +0800, zelong dong wrote:
> >> From: Zelong Dong <zelong.dong@...ogic.com>
> >>
> >> Add new compatible and DT bindings for Amlogic C3 Reset Controller
> >>
> >> Signed-off-by: Zelong Dong <zelong.dong@...ogic.com>
> >> ---
> >>  .../bindings/reset/amlogic,meson-reset.yaml   |   1 +
> >>  include/dt-bindings/reset/amlogic,c3-reset.h  | 119 ++++++++++++++++++
> >>  2 files changed, 120 insertions(+)
> > 
> > As I understand it, updates to DT bindings documentation, as well as any
> > DT bindings includes, should be submitted in separate patches, per the
> > guidelines outlined in the following link:
> > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters.
> > 
> > Krzysztof, Rob, and Conor, please correct me if I am mistaken.
> 
> And they are. What's wrong here?

Please accept my apologies for any confusion caused. Initially, I
misunderstood that YAML documentation and device tree bindings includes
should be kept separate.

As such, this patch includes modifications to both areas, namely
bindings documentation and include/dt-bindings, but all of them are
separate from driver part.

In this case,

Reviewed-by: Dmitry Rokosov <ddrokosov@...rdevices.ru>

-- 
Thank you,
Dmitry