linux-kernel - Re: Misbehavior with setsockopt timeval structure with -fpack-struct enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <41150408e841274d792ef0a905ee1c52@mu-ori.me>
Date:   Wed, 19 Jul 2023 14:14:57 +0000
From:   "Drew B." <subs@...ori.me>
To:     David Laight <David.Laight@...lab.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: Misbehavior with setsockopt timeval structure with -fpack-struct
 enabled

Hi David!
Thanks for your answer. Just to feed my curiosity, why? Of course I 
could use:
#pragma pack(1, push)
...
#pragma pack(pop)
to pack only what is needed, but in the first place I was thinking about 
keeping as much free memory as possible (to make things optimized). And 
keep other things intact, but is it not a good practice placing 
-fpack-struct into compile-time params?

Kind regards,
Drew.

On 2023-07-19 13:36, David Laight wrote:
> ...
>> with -fpack-struct enabled,
> 
> Don't even think of enabling that.
> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, 
> MK1 1PT, UK
> Registration No: 1397386 (Wales)