[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230719145534.9812-1-martijn@brixit.nl>
Date: Wed, 19 Jul 2023 16:55:33 +0200
From: Martijn Braam <martijn@...xit.nl>
To: unlisted-recipients:; (no To-header on input)
Cc: Martijn Braam <martijn@...xit.nl>,
Dafna Hirschfeld <dafna@...tmail.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Heiko Stuebner <heiko@...ech.de>, linux-media@...r.kernel.org,
linux-rockchip@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] media: rkisp1: Promote link validation error to dev_err
Show an error when the pipeline cannot start due to an invalid link
instead of hiding it behind the debugging system.
Signed-off-by: Martijn Braam <martijn@...xit.nl>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
index 8f3cba319762..9361b9086f6b 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
@@ -1340,7 +1340,7 @@ static int rkisp1_capture_link_validate(struct media_link *link)
if (sd_fmt.format.height != cap->pix.fmt.height ||
sd_fmt.format.width != cap->pix.fmt.width ||
sd_fmt.format.code != fmt->mbus) {
- dev_dbg(cap->rkisp1->dev,
+ dev_err(cap->rkisp1->dev,
"link '%s':%u -> '%s':%u not valid: 0x%04x/%ux%u != 0x%04x/%ux%u\n",
link->source->entity->name, link->source->index,
link->sink->entity->name, link->sink->index,
--
2.40.0
Powered by blists - more mailing lists