linux-kernel - Re: [PATCH v1] mtd: spi-nor: macronix: Add support for MX77U25650F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6725f64-7d08-5966-e0bc-17c5b2e846ad@linaro.org>
Date:   Wed, 19 Jul 2023 16:18:56 +0100
From:   Tudor Ambarus <tudor.ambarus@...aro.org>
To:     mahesh.r.vaidya@...el.com, pratyush@...nel.org, michael@...le.cc,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     andriy.shevchenko@...ux.intel.com, jarkko.nikula@...el.com,
        furong.zhou@...el.com, mallikarjunappa.sangannavar@...el.com,
        nandhini.srikandan@...el.com, rashmi.a@...el.com
Subject: Re: [PATCH v1] mtd: spi-nor: macronix: Add support for MX77U25650F

Hi,

On 7/19/23 14:27, mahesh.r.vaidya@...el.com wrote:
> From: Mahesh R Vaidya <mahesh.r.vaidya@...el.com>
> 
> The MX7725650F is production chip for new design from Macronix
> with a lesser memory of 256Mbit with unique security features
> like Permanent 4 I/O RPMC, Secured 8K OTP support.
> 
> Validated by read, erase, write and read back.
> Tested on Intel RPL, PASS.
> Tested-by: Mahesh R Vaidya <mahesh.r.vaidya@...el.com>
> 
> Signed-off-by: Mahesh R Vaidya <mahesh.r.vaidya@...el.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/mtd/spi-nor/macronix.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index 04888258e891..995936ba58e2 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -103,6 +103,9 @@ static const struct flash_info macronix_nor_parts[] = {
>  	{ "mx66u2g45g",	 INFO(0xc2253c, 0, 64 * 1024, 4096)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
>  		FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
> +	{ "mx77u25650f",  INFO(0xc27539, 0, 64 * 1024, 512)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> +		FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
>  };
>  

Does this flash support SFDP tables? Here's how you can
determine that:
https://lore.kernel.org/linux-mtd/cover.1686557139.git.Takahiro.Kuwano@infineon.com/

If yes, then you could use the generic spi-nor driver,
thus you won't need to explicitly define a flash entry,
See:
773bbe104497 mtd: spi-nor: add generic flash driver