linux-kernel - Re: [PATCH] blk-mq: delete dead struct blk_mq_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2d10567-cfc6-de6b-cc08-21ab00604d51@acm.org>
Date:   Thu, 20 Jul 2023 08:36:22 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     chengming.zhou@...ux.dev, axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhouchengming@...edance.com
Subject: Re: [PATCH] blk-mq: delete dead struct blk_mq_hw_ctx->queued field

On 7/20/23 02:55, chengming.zhou@...ux.dev wrote:
> From: Chengming Zhou <zhouchengming@...edance.com>
> 
> This counter is not used anywhere, so delete it.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> ---
>   include/linux/blk-mq.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> index 01e8c31db665..958ed7e89b30 100644
> --- a/include/linux/blk-mq.h
> +++ b/include/linux/blk-mq.h
> @@ -393,8 +393,6 @@ struct blk_mq_hw_ctx {
>   	 */
>   	struct blk_mq_tags	*sched_tags;
>   
> -	/** @queued: Number of queued requests. */
> -	unsigned long		queued;
>   	/** @run: Number of dispatched requests. */
>   	unsigned long		run;

Reviewed-by: Bart Van Assche <bvanassche@....org>