[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZLljYqE_gDzh_WgT@orome>
Date: Thu, 20 Jul 2023 18:40:02 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Mohan Kumar <mkumard@...dia.com>
Cc: treding@...dia.com, jonathanh@...dia.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org, spujar@...dia.com
Subject: Re: [PATCH] arm64: tegra: Add audio support for IGX Orin
On Thu, Jul 20, 2023 at 06:39:32PM +0200, Thierry Reding wrote:
> On Tue, Jun 20, 2023 at 09:28:47PM +0530, Mohan Kumar wrote:
> > Add audio support for the NVIDIA IGX Orin development kit having P3701
> > module with P3740 carrier board.
> >
> > Move the common device-tree nodes to a new file tegra234-p3701.dtsi and
> > use this for Jetson AGX Orin and NVIDIA IGX Orin platforms
> >
> > Signed-off-by: Mohan Kumar <mkumard@...dia.com>
> > ---
> > .../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 1 +
> > .../boot/dts/nvidia/tegra234-p3701-0008.dtsi | 1 +
> > .../arm64/boot/dts/nvidia/tegra234-p3701.dtsi | 1991 ++++++++++++++++
> > .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 2009 -----------------
> > .../boot/dts/nvidia/tegra234-p3737-0000.dtsi | 41 +
> > .../nvidia/tegra234-p3740-0002+p3701-0008.dts | 91 +-
> > .../boot/dts/nvidia/tegra234-p3740-0002.dtsi | 56 +
> > 7 files changed, 2176 insertions(+), 2014 deletions(-)
> > create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi
> [...]
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> > index 43d797e5544f..2b7856b303b4 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> [...]
> > @@ -103,7 +99,7 @@
> > };
> >
> > hda@...0000 {
> > - nvidia,model = "NVIDIA IGX HDA";
> > + nvidia,model = "NVIDIA Jetson IGX Orin HDA";
> [...]
> > @@ -151,4 +147,89 @@
> [...]
> > + label = "NVIDIA Jetson IGX Orin APE";
> [...]
>
> The platform is called "NVIDIA IGX Orin Development Kit", so shouldn't
> these be "NVIDIA IGX Orin HDA" and "NVIDIA IGX Orin APE", respectively?
Oh, and no need to resend, I can fix this up when I apply.
Thierry
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists