linux-kernel - Re: [PATCH] tools/power/x86/intel-speed-select: Support more than 8 sockets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9befc235e14b8a8ca539c95eadcc4bff2d758d1.camel@linux.intel.com>
Date:   Thu, 20 Jul 2023 09:46:16 -0700
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Frank Ramsay <frank.ramsay@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Russ Anderson <russ.anderson@....com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Support more than 8
 sockets.

On Thu, 2023-07-20 at 11:08 -0500, Frank Ramsay wrote:
> MAX_PACKAGE_COUNT limits the intel-speed-select to systems with 8
> sockets or fewer.
> On a system with more than 8 sockets intel-speed-select silently
> ignores everything
> beyond the 8th socket, rendering the tool useless for those systems.
> 
> Increase MAX_PACKAGE_COUNT to support systems with up to 32 sockets.
> 
Thanks for the patch. I will queue this for the next release.

-Srinivas

> Signed-off-by: Frank Ramsay <frank.ramsay@....com>
> ---
>  tools/power/x86/intel-speed-select/isst.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/x86/intel-speed-select/isst.h
> b/tools/power/x86/intel-speed-select/isst.h
> index 54fc21575d56..8def22dec4a2 100644
> --- a/tools/power/x86/intel-speed-select/isst.h
> +++ b/tools/power/x86/intel-speed-select/isst.h
> @@ -79,7 +79,7 @@
>  
>  #define DISP_FREQ_MULTIPLIER 100
>  
> -#define MAX_PACKAGE_COUNT      8
> +#define MAX_PACKAGE_COUNT      32
>  #define MAX_DIE_PER_PACKAGE    2
>  #define MAX_PUNIT_PER_DIE      8
>