linux-kernel - Re: [PATCH] NFSv4/pnfs: minor fix for cleanup path in nfs4_get_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BAB89FB2-C67B-417C-9C53-D3F06D781586@redhat.com>
Date:   Thu, 20 Jul 2023 12:53:26 -0400
From:   Benjamin Coddington <bcodding@...hat.com>
To:     Fedor Pchelkin <pchelkin@...ras.ru>
Cc:     Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org, stable@...r.kernel.org
Subject: Re: [PATCH] NFSv4/pnfs: minor fix for cleanup path in
 nfs4_get_device_info

On 20 Jul 2023, at 11:37, Fedor Pchelkin wrote:

> It is an almost improbable error case but when page allocating loop in
> nfs4_get_device_info() fails then we should only free the already
> allocated pages, as __free_page() can't deal with NULL arguments.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Cc: stable@...r.kernel.org
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>

This looks correct to me.

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>

Ben