linux-kernel - Re: [PATCH v2] KVM: arm64: Fix hardware enable/disable flows for pKVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168987354993.692466.16634039861064795931.b4-ty@linux.dev>
Date:   Thu, 20 Jul 2023 17:19:22 +0000
From:   Oliver Upton <oliver.upton@...ux.dev>
To:     Marc Zyngier <maz@...nel.org>,
        Raghavendra Rao Ananta <rananta@...gle.com>
Cc:     Oliver Upton <oliver.upton@...ux.dev>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Fuad Tabba <tabba@...gle.com>, Will Deacon <will@...nel.org>,
        kvmarm@...ts.linux.dev, Jing Zhang <jingzhangos@...gle.com>,
        James Morse <james.morse@....com>,
        Colton Lewis <coltonlewis@...gle.com>,
        Reiji Watanabe <reijiw@...gle.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Fix hardware enable/disable flows for pKVM

On Wed, 19 Jul 2023 21:57:25 +0000, Raghavendra Rao Ananta wrote:
> When running in protected mode, the hyp stub is disabled after pKVM is
> initialized, meaning the host cannot enable/disable the hyp at
> runtime. As such, kvm_arm_hardware_enabled is always 1 after
> initialization, and kvm_arch_hardware_enable() never enables the vgic
> maintenance irq or timer irqs.
> 
> Unconditionally enable/disable the vgic + timer irqs in the respective
> calls, instead relying on the percpu bookkeeping in the generic code
> to keep track of which cpus have the interrupts unmasked.
> 
> [...]

Applied to kvmarm/fixes, thanks!

[1/1] KVM: arm64: Fix hardware enable/disable flows for pKVM
      https://git.kernel.org/kvmarm/kvmarm/c/c718ca0e9940

--
Best,
Oliver