linux-kernel - Re: [PATCH] tracing: add missing spaces after ';'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230720134501.01f9f1de@gandalf.local.home>
Date:   Thu, 20 Jul 2023 13:45:01 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     wuyonggang001@...suo.com
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: add missing spaces after ';'

On Thu, 20 Jul 2023 10:30:36 +0800
wuyonggang001@...suo.com wrote:

> Remove spaces to clear checkpatch errors.
> 
> ERROR: space required after that ';' (ctx:VxV)

PLEASE DO NOT RUN CHECKPATCH ON CURRENT CODE!!!!

As the name suggests, checkpatch is for patches and not for existing code.
It is used as a guideline tool to make clean patches. But checkpatch is
*NOT* the rule of the kernel. There's lots of issues that checkpatch
reports that can be ignored. That is decided when the patch is submitted,
and SHOULD NOT be revisited once it has been accepted. Not to mention this
particular error is silly.

NACK!!!

-- Steve

> 
> Signed-off-by: Yonggang Wu <wuyonggang001@...suo.com>
> ---
>   include/trace/stages/stage4_event_fields.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/stages/stage4_event_fields.h 
> b/include/trace/stages/stage4_event_fields.h
> index b6f679ae21aa..9627e081a990 100644
> --- a/include/trace/stages/stage4_event_fields.h
> +++ b/include/trace/stages/stage4_event_fields.h
> @@ -2,7 +2,7 @@
> 
>   /* Stage 4 definitions for creating trace events */
> 
> -#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;})))
> +#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; })))
> 
>   #undef __field_ext
>   #define __field_ext(_type, _item, _filter_type) {            \