[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <77b0bd8a-0168-f7c1-9aa0-a40359d2f075@intel.com>
Date: Thu, 20 Jul 2023 20:18:22 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Yunsheng Lin <linyunsheng@...wei.com>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Eric Dumazet <edumazet@...gle.com>,
Wei Fang <wei.fang@....com>,
Shenwei Wang <shenwei.wang@....com>,
Clark Wang <xiaoning.wang@....com>,
NXP Linux Team <linux-imx@....com>,
Sunil Goutham <sgoutham@...vell.com>,
Geetha sowjanya <gakula@...vell.com>,
Subbaraya Sundeep <sbhatta@...vell.com>,
hariprasad <hkelam@...vell.com>,
Saeed Mahameed <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Jesper Dangaard Brouer <hawk@...nel.org>,
"John Fastabend" <john.fastabend@...il.com>,
Felix Fietkau <nbd@....name>,
"Lorenzo Bianconi" <lorenzo@...nel.org>,
Ryder Lee <ryder.lee@...iatek.com>,
"Shayne Chen" <shayne.chen@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>,
"Kalle Valo" <kvalo@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
"Ilias Apalodimas" <ilias.apalodimas@...aro.org>,
<linux-rdma@...r.kernel.org>, <bpf@...r.kernel.org>,
<linux-wireless@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next] page_pool: split types and declarations from
page_pool.h
From: Alexander Lobakin <aleksander.lobakin@...el.com>
Date: Wed, 19 Jul 2023 18:42:17 +0200
> From: Yunsheng Lin <linyunsheng@...wei.com>
> Date: Wed, 19 Jul 2023 20:13:37 +0800
>
>> Split types and pure function declarations from page_pool.h
>> and add them in page_page_types.h, so that C sources can
>> include page_pool.h and headers should generally only include
>> page_pool_types.h as suggested by jakub.
>>
>> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
>> Suggested-by: Jakub Kicinski <kuba@...nel.org>
>> CC: Alexander Lobakin <aleksander.lobakin@...el.com>
> Nice!
>
> Let me take it into my tree, I assume it's safe to say it will be
> accepted sooner than my patches :D
FYI: it's already there (since yesterday), including your hybrid
allocation series, so for the next revision you could take it from there
to not rebase it one more time :)
...except that seems like I have to rebase it once again now that you
change the patch to add new folder as Jakub asked.
(it's still the same iavf-pp-frag)
>
> BTW, what do you think: is it better to have those two includes in the
> root include/net/ folder or do something like
>
> include/net/page_pool/
> * types.h
> * <some meaningful name>.h (let's say driver.h)
>
> like it's done e.g. for GPIO (see include/linux/gpio/)?
>
> Thanks,
> Olek
Thanks,
Olek
Powered by blists - more mailing lists