linux-kernel - Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230720194037.60d109d7@jic23-huawei>
Date:   Thu, 20 Jul 2023 19:40:37 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alejandro Tafalla <atafalla@...on.com>
Cc:     Lorenzo Bianconi <lorenzo@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval

On Mon, 17 Jul 2023 23:17:10 +0200
Alejandro Tafalla <atafalla@...on.com> wrote:

> On sábado, 15 de julio de 2023 19:35:15 (CEST) Jonathan Cameron wrote:
> > On Fri, 14 Jul 2023 17:31:26 +0200
> > 
> > Alejandro Tafalla <atafalla@...on.com> wrote:  
> > > The function lsm6dsx_get_acpi_mount_matrix should return an error when
> > > ACPI
> > > support is not enabled to allow executing iio_read_mount_matrix in the
> > > probe function.
> > > 
> > > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")  
> > 
> > I can fix it up whilst applying if no other issues, but there must not be
> > a blank line here.  All tags need to be in a single block for some tooling
> > that is used with the kernel tree (and some of the checking scripts warn
> > about this so it won't get applied with the blank line here).  
> 
> Okay, i'll keep it in mind for new patches. Thank you.
Np.

Just waiting for Lorenzo to have time to take a final look.

Jonathan

> >   
> > > Signed-off-by: Alejandro Tafalla <atafalla@...on.com>
> > > ---
> > > Changes in v3:
> > > - Removed unneeded check for err == -EOPNOTSUPP.
> > > 
> > > Changes in v2:
> > > - Use of error codes instead of true/false
> > > 
> > >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index
> > > 6a18b363cf73..b6e6b1df8a61 100644
> > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > > device *dev,> 
> > >  static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> > >  
> > >  					  struct   
> iio_mount_matrix *orientation)
> > >  
> > >  {
> > > 
> > > -	return false;
> > > +	return -EOPNOTSUPP;
> > > 
> > >  }
> > >  
> > >  #endif  
> 
> 
> 
>