[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fXQY1T2VQxs2ZBX_9ksuVfYvvzA6xSeOUpSQ8Sz1eJv_Q@mail.gmail.com>
Date: Wed, 19 Jul 2023 21:32:57 -0700
From: Ian Rogers <irogers@...gle.com>
To: Rong Qianfeng <rongqianfeng@...o.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
opensource.kernel@...o.com
Subject: Re: [PATCH] tools: perf: Two typos have been corrected
On Wed, Jul 19, 2023 at 8:40 PM Rong Qianfeng <rongqianfeng@...o.com> wrote:
>
> When wrapping code, use ';' better than using ',' which is more
> in line with the coding habits of most engineers.
>
> Signed-off-by: Rong Qianfeng <rongqianfeng@...o.com>
Snap: https://lore.kernel.org/lkml/20230706094635.1553-1-luhongfei@vivo.com/
Thanks,
Ian
> ---
> tools/perf/builtin-diff.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index e8a1b16aa5f8..57d300d8e570
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1915,8 +1915,8 @@ static int data_init(int argc, const char **argv)
> struct perf_data *data = &d->data;
>
> data->path = use_default ? defaults[i] : argv[i];
> - data->mode = PERF_DATA_MODE_READ,
> - data->force = force,
> + data->mode = PERF_DATA_MODE_READ;
> + data->force = force;
>
> d->idx = i;
> }
> --
> 2.39.0
>
Powered by blists - more mailing lists