linux-kernel - Re: [PATCH] iommu/apple-dart: mark apple_dart_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f176c331-f8cf-4a44-8ada-7d9c958b17ca@app.fastmail.com>
Date:   Thu, 20 Jul 2023 20:53:26 +0200
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Min-Hua Chen" <minhuadotchen@...il.com>,
        "Hector Martin" <marcan@...can.st>,
        "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
        "Joerg Roedel" <joro@...tes.org>, "Will Deacon" <will@...nel.org>,
        "Robin Murphy" <robin.murphy@....com>
Cc:     asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static

On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote:
> This patch fixes the following sprse warning:

typo: sparse

>
> drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 
> 'apple_dart_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>
> ---

Acked-by: Sven Peter <sven@...npeter.dev>

Thanks,


Sven

>  drivers/iommu/apple-dart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 8af64b57f048..2082081402d3 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -1276,7 +1276,7 @@ static __maybe_unused int 
> apple_dart_resume(struct device *dev)
>  	return 0;
>  }
> 
> -DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, 
> apple_dart_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, 
> apple_dart_resume);
> 
>  static const struct of_device_id apple_dart_of_match[] = {
>  	{ .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
> -- 
> 2.34.1