[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1e16e400-0dbb-4ba1-a0a5-2380b50fa60a@app.fastmail.com>
Date: Thu, 20 Jul 2023 20:55:34 +0200
From: "Sven Peter" <sven@...npeter.dev>
To: "Min-Hua Chen" <minhuadotchen@...il.com>,
"Hector Martin" <marcan@...can.st>,
"Alyssa Rosenzweig" <alyssa@...enzweig.io>,
"Philipp Zabel" <p.zabel@...gutronix.de>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static
On Thu, Jul 20, 2023, at 00:38, Min-Hua Chen wrote:
> This patch fixes the following sparse warnings:
>
> drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol
> 'apple_pmgr_reset_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>
> ---
Acked-by: Sven Peter <sven@...npeter.dev>
Thanks,
Sven
> drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c
> b/drivers/soc/apple/apple-pmgr-pwrstate.c
> index d62a776c89a1..9467235110f4 100644
> --- a/drivers/soc/apple/apple-pmgr-pwrstate.c
> +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c
> @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct
> reset_controller_dev *rcdev, unsigned
> return !!(reg & APPLE_PMGR_RESET);
> }
>
> -const struct reset_control_ops apple_pmgr_reset_ops = {
> +static const struct reset_control_ops apple_pmgr_reset_ops = {
> .assert = apple_pmgr_reset_assert,
> .deassert = apple_pmgr_reset_deassert,
> .reset = apple_pmgr_reset_reset,
> --
> 2.34.1
Powered by blists - more mailing lists