linux-kernel - Re: [PATCH v8 1/2] docs: Move rustdoc output, cross-reference it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nqTnao=Xm=vA_OWb7sss02WhwTsj37HpKSz2bSF+4pdA@mail.gmail.com>
Date:   Thu, 20 Jul 2023 21:07:12 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Carlos Bilbao <carlos.bilbao@....com>
Cc:     corbet@....net, ojeda@...nel.org, jani.nikula@...ux.intel.com,
        rdunlap@...radead.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, konstantin@...uxfoundation.org,
        rust-for-linux@...r.kernel.org, Akira Yokosawa <akiyks@...il.com>
Subject: Re: [PATCH v8 1/2] docs: Move rustdoc output, cross-reference it

On Tue, Jul 18, 2023 at 5:15 PM Carlos Bilbao <carlos.bilbao@....com> wrote:
>
> Reviewed-by: Akira Yokosawa <akiyks@...il.com>

Just in case: does this Reviewed-by still apply? (and the one in the
other commit)

> +.. only:: rustdoc and html
> +
> +       You can also browse `rustdoc documentation <rustdoc/kernel/index.html>`_.
> +
> +.. only:: not rustdoc and html
> +
> +       This documentation does not include rustdoc generated information.
> +

(I will move here a couple notes from v7 to avoid losing them, since
we were discussing there and then v8 was sent.)

I would move this to its own commit or to where the variable is
defined, but it is not critical since Carlos confirmed it does not
break the build.

> +# Where to place rustdoc generated documentation
> +rustdoc_output := $(objtree)/Documentation/output/rust/rustdoc

(From v7 too) Should this take into account `BUILDDIR`?

Cheers,
Miguel