linux-kernel - Re: [PATCH v5 2/5] gpio: gxp: Add HPE GXP GPIO PL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9EABEF68-9261-416F-87FA-6DFDF7A5376A@hpe.com>
Date:   Thu, 20 Jul 2023 20:26:51 +0000
From:   "Hawkins, Nick" <nick.hawkins@....com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
CC:     "Verdun, Jean-Marie" <verdun@....com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH v5 2/5] gpio: gxp: Add HPE GXP GPIO PL


> > +
> > +/*
> > + * When an interrupt fires for a PSU config change
> > + * there is a need to know the previous PSU configuration
> > + * so that the appropriate gpio line is interrupted for
> > + * the correct PSU. In order to keep this variable up to
> > + * date it is global so that it can be set at init and
> > + * each time the interrupt fires.
> > + */
> > +u8 psu_presence;

> I'm not buying it. There's no user of this variable outside of this
> compilation unit, is there? If there was - the name should have some
> prefix but even then, I don't see a need for this to be global. Why
> don't you put it in struct gxp_gpio_drvdata?

Hi Bart,

You are correct this should not be global. It will be placed in 
gxp_gpio_drvdata.

Thank you for catching this and the assistance,

-Nick Hawkins