linux-kernel - Re: [PATCH] mm/percpu.c: change GFP_KERNEL to GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLnGjanv23R8O4FU@MiWiFi-R3L-srv>
Date:   Fri, 21 Jul 2023 07:43:09 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     sunran001@...suo.com, dennis@...nel.org, tj@...nel.org,
        cl@...ux.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/percpu.c: change GFP_KERNEL to GFP_ATOMIC

On 07/18/23 at 10:17am, Andrew Morton wrote:
> On Tue, 18 Jul 2023 14:35:11 +0800 sunran001@...suo.com wrote:
> 
> > ERROR: function pcpu_balance_populated called on line 2238 inside lock
> > on line 2234 but uses GFP_KERNEL
> > 
> > Generated by: scripts/coccinelle/locks/call_kern.cocci
> > 
> > ...
> >
> > --- a/mm/percpu.c
> > +++ b/mm/percpu.c
> > @@ -2033,7 +2033,7 @@ static void pcpu_balance_free(bool empty_only)
> >   static void pcpu_balance_populated(void)
> >   {
> >       /* gfp flags passed to underlying allocators */
> > -    const gfp_t gfp = GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN;
> > +    const gfp_t gfp = GFP_ATOMIC | __GFP_NORETRY | __GFP_NOWARN;
> >       struct pcpu_chunk *chunk;
> >       int slot, nr_to_pop, ret;
> 
> I don't believe this warning is correct.  

Yeah, the warning is false positive. It releases the lock when
requesting memory allocation, then take the lock again.

> 
> 			spin_unlock_irq(&pcpu_lock);
> 			ret = pcpu_populate_chunk(chunk, rs, rs + nr, gfp);
> 			cond_resched();
> 			spin_lock_irq(&pcpu_lock);
>