[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9c6efec0-42ae-6b48-dd42-0ed7a0d5544d@linux.alibaba.com>
Date: Thu, 20 Jul 2023 14:09:49 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, akpm@...ux-foundation.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm/compaction: avoid unneeded pageblock_end_pfn when
no_set_skip_hint is set
On 7/20/2023 7:53 PM, Kemeng Shi wrote:
> Move pageblock_end_pfn after no_set_skip_hint check to avoid unneeded
> pageblock_end_pfn if no_set_skip_hint is set.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
> mm/compaction.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index c0d8d08fc163..9b7a0a69e19f 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -458,12 +458,12 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn)
> {
> struct zone *zone = cc->zone;
>
> - pfn = pageblock_end_pfn(pfn);
> -
> /* Set for isolation rather than compaction */
> if (cc->no_set_skip_hint)
> return;
>
> + pfn = pageblock_end_pfn(pfn);
> +
> if (pfn > zone->compact_cached_migrate_pfn[0])
> zone->compact_cached_migrate_pfn[0] = pfn;
> if (cc->mode != MIGRATE_ASYNC &&
Powered by blists - more mailing lists