[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0ad5a223-d70f-deaa-6261-a2bd2b2af40d@linaro.org>
Date: Thu, 20 Jul 2023 08:15:21 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: James Hilliard <james.hilliard1@...il.com>,
devicetree@...r.kernel.org
Cc: Gregory CLEMENT <gregory.clement@...tlin.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
soc@...nel.org, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Marek Vasut <marex@...x.de>,
Frieder Schrempf <frieder.schrempf@...tron.de>,
Stefan Wahren <stefan.wahren@...rgebyte.com>,
Andreas Kemnade <andreas@...nade.info>,
Michal Vokáč <michal.vokac@...ft.com>,
Marcel Ziswiler <marcel.ziswiler@...adex.com>,
Jesse Taube <mr.bossman075@...il.com>,
Li Yang <leoyang.li@....com>, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: dts: imx6q: Add Variscite MX6 Custom board
support
On 20/07/2023 00:41, James Hilliard wrote:
> This patch adds support for the Variscite MX6 SoM Carrier Board.
>
> This Carrier-Board has the following :
> - LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display
> - HDMI Connector
> - USB Host + USB OTG Connector
> - 10/100/1000 Mbps Ethernet
> - miniPCI-Express slot
> - SD Card connector
> - Audio Headphone/Line In jack connectors
> - S-ATA
> - On-board DMIC
> - RS485 Header
> - CAN bus header
> - SPI header
> - Camera Interfaces header
> - OnBoard RTC with Coin Backup battery socket
> - RS232 Debug Header (IDC10)
> - RS232 DTE
>
> Product Page : https://www.variscite.com/product/single-board-computers/var-mx6customboard
>
> The dts file based on the ones provided by Variscite on their own
> kernel, but adapted for mainline.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
> Signed-off-by: James Hilliard <james.hilliard1@...il.com>
> ---
> .../devicetree/bindings/arm/fsl.yaml | 1 +
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
> arch/arm/boot/dts/Makefile | 1 +
> .../arm/boot/dts/imx6q-var-mx6customboard.dts | 279 ++++++++++++++++++
> 3 files changed, 281 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6q-var-mx6customboard.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 15d411084065..0f583852de8a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -298,6 +298,7 @@ properties:
> - udoo,imx6q-udoo # Udoo i.MX6 Quad Board
> - uniwest,imx6q-evi # Uniwest Evi
> - variscite,dt6customboard
> + - variscite,mx6customboard
> - wand,imx6q-wandboard # Wandboard i.MX6 Quad Board
> - ysoft,imx6q-yapp4-crux # i.MX6 Quad Y Soft IOTA Crux board
> - ysoft,imx6q-yapp4-pegasus # i.MX6 Quad Y Soft IOTA Pegasus board
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 59829fc90315..9cfc3d3e91ea 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -665,6 +665,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6q-udoo.dtb \
> imx6q-utilite-pro.dtb \
> imx6q-var-dt6customboard.dtb \
> + imx6q-var-mx6customboard.dtb \
> imx6q-vicut1.dtb \
> imx6q-wandboard.dtb \
> imx6q-wandboard-revb1.dtb \
> diff --git a/arch/arm/boot/dts/imx6q-var-mx6customboard.dts b/arch/arm/boot/dts/imx6q-var-mx6customboard.dts
> new file mode 100644
> index 000000000000..66047dff11ec
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-var-mx6customboard.dts
> @@ -0,0 +1,279 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Support for Variscite MX6 Carrier-board
> + *
> + * Copyright 2016 Variscite, Ltd. All Rights Reserved
> + * Copyright 2022 Bootlin
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6qdl-var-som.dtsi"
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Variscite i.MX6 QUAD/DUAL VAR-SOM-MX6 Custom Board";
> + compatible = "variscite,mx6customboard", "fsl,imx6q";
Where is the SoM compatible?
Best regards,
Krzysztof
Powered by blists - more mailing lists