linux-kernel - Re: [PATCH v2 6/7] rust: support running Rust documentation tests as KUnit ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSnL0Kiv1Mo6feCLYVq6bGUjxN3gUVrW4ZKD4Fh1wUhWrQ@mail.gmail.com>
Date:   Thu, 20 Jul 2023 14:36:50 +0800
From:   David Gow <davidgow@...gle.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Brendan Higgins <brendan.higgins@...ux.dev>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Benno Lossin <benno.lossin@...ton.me>,
        Alice Ryhl <aliceryhl@...gle.com>,
        Andreas Hindborg <nmi@...aspace.dk>,
        kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...ts.linux.dev
Subject: Re: [PATCH v2 6/7] rust: support running Rust documentation tests as
 KUnit ones

On Tue, 18 Jul 2023 at 18:50, Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Tue, Jul 18, 2023 at 10:17 AM David Gow <davidgow@...gle.com> wrote:
> >
> > This is looking good and working well here.
> >
> > One super-minor thought below (the generated C file seems to be using
> > 4-space indentation, not tabs), but it's not something that worries me
> > enough to hold the patch up if there are no other issues.
>
> Good eye! Of course, please feel free to change it when applying
> (though from a quick grep I don't see "[ ... ]" comments in commits in
> the KUnit tree). I am also happy to send a v3.

We merged this as-is, and I've sent out a fixup patch here:
https://lore.kernel.org/linux-kselftest/20230720062939.2411889-1-davidgow@google.com/T/#u

I wasn't able to find any issues with changing the indentation, but
let me know if there's some tool which complains about seeing tabs in
.rs files we need to worry about.

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)