linux-kernel - Re: [PATCH] parisc: math-emu: fcnvxf: Add space after that ','

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5603e84b-656b-e0b2-14ef-13f4e1062552@gmx.de>
Date:   Thu, 20 Jul 2023 08:49:27 +0200
From:   Helge Deller <deller@....de>
To:     hanyu001@...suo.com
Cc:     linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: math-emu: fcnvxf: Add space after that ','

Hello hanyu001,

On 7/13/23 11:37, hanyu001@...suo.com wrote:
>
> Fix Error reported by checkpatch.pl
>
> arch/parisc/math-emu/fcnvxf.c:99: ERROR: space required after that ',' (ctx:VxV
> )
>
> Signed-off-by: maqimei <2433033762@...com>

Thanks for that patch!

Your patch is correct and as such it should be applied.
But please notice the arch/parisc/math-emu/README file (in the same
directory), which states:
All files except driver.c are snapshots from the HP-UX kernel.  They've
been modified as little as possible.  Even though they don't fit the
Linux coding style, please leave them in their funny format just in case
someone in the future, with access to HP-UX source code, is generous
enough to update our copies with later changes from HP-UX -- it'll
make their 'diff' job easier if our code is relatively unmodified.

So, I won't apply any patch to that directory, unless it fixes a real bug
or is required to compile the kernel.

Thanks,
Helge

> ---
>   arch/parisc/math-emu/fcnvxf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/parisc/math-emu/fcnvxf.c b/arch/parisc/math-emu/fcnvxf.c
> index 6940179..f5f9376 100644
> --- a/arch/parisc/math-emu/fcnvxf.c
> +++ b/arch/parisc/math-emu/fcnvxf.c
> @@ -96,7 +96,7 @@
>                       Sgl_increment(result);
>                   break;
>               case ROUNDNEAREST:
> -                Sgl_roundnearest_from_int(src,result);
> +                Sgl_roundnearest_from_int(src, result);
>           }
>           if (Is_inexacttrap_enabled()) {
>               *dstptr = result;