linux-kernel - Re: [PATCH net v1] ath6kl:Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87jzuv3w8x.fsf@kernel.org>
Date:   Thu, 20 Jul 2023 09:58:06 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Wang Ming <machel@...o.com>, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir()

Paolo Abeni <pabeni@...hat.com> writes:

> On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote:
>> The debugfs_create_dir() function returns error pointers,
>> it never returns NULL. Most incorrect error checks were fixed,
>> but the one in ath6kl_debug_init_fs() was forgotten.
>> 
>> Fix the remaining error check.
>> 
>> Signed-off-by: Wang Ming <machel@...o.com>
>> 
>> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs")
>
> The SoB tag should be after the 'Fixes' one and you must avoid empty
> lines in between.
>
> (The same applies to your other patch)

And the same as with the ath9k patch: this should go to ath-next, not
net.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches