linux-kernel - Re: [PATCH V1 1/1] linux: drivers: mtd: spi-nor: gigadevice.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62663146a51c2beac4eff48abe1f61f8@walle.cc>
Date:   Thu, 20 Jul 2023 09:05:15 +0200
From:   Michael Walle <michael@...le.cc>
To:     Victor Lim <vlim@...adevice.com>
Cc:     tudor.ambarus@...aro.org, pratyush@...nel.org,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        akumarma@....com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, vikhyat.goyal@....com,
        Victor Lim <vlim@...adevice.com>
Subject: Re: [PATCH V1 1/1] linux: drivers: mtd: spi-nor: gigadevice.c

Am 2023-07-20 06:28, schrieb Victor Lim:
> Adding gigedevice new part numbers
> 
> Signed-off-by: Victor Lim <vlim@...adevice.com>

This is already v3 of this series. Please track and keep a change log.

Your previous ones were here:
https://lore.kernel.org/linux-mtd/20221204080000.4100-1-vlim@gigadevice.com/
https://lore.kernel.org/linux-mtd/20221206111037.8999-1-vlim@gigadevice.com/

> ---
>  drivers/mtd/spi-nor/gigadevice.c | 79 ++++++++++++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/gigadevice.c 
> b/drivers/mtd/spi-nor/gigadevice.c
> index d57ddaf1525b..285fa42f2d97 100644
> --- a/drivers/mtd/spi-nor/gigadevice.c
> +++ b/drivers/mtd/spi-nor/gigadevice.c
> @@ -67,6 +67,85 @@ static const struct flash_info 
> gigadevice_nor_parts[] = {
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6)
>  		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
>  		.fixups = &gd25q256_fixups },
> +/* adding these parts */

Why this comment?

> +	{ "gd25lx256e",  INFO(0xc86819, 0, 64 * 1024, 512,
> +			      SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
> +			      SPI_NOR_4B_OPCODES | SPI_NOR_OCTAL_DTR_READ |
> +			      SPI_NOR_OCTAL_DTR_PP |
> +			      SPI_NOR_IO_MODE_EN_VOLATILE)
> +		.fixups = &gd25lx256e_fixups },
> +	{"gd25b512", INFO(0xc8471A, 0, 64 * 1024, 1024,	SECT_4K |
> +	SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},

Did you even compile this? INFO() doesn't take 5 arguments.
I'll stop here.

If you decide to post another version. Please read through all
the feedback you've got and esp. 
Documentation/process/submitting-patches.rst

Make it one patch per added part, don't include legacy flags if not 
needed,
include a test report and the dump of the SFDP tables.

Thanks,
-michael