linux-kernel - Re: linux-next: build failure after merge of the cifs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C27A47B8189477B4+20230720093334.2682929e@winn-pc>
Date:   Thu, 20 Jul 2023 09:33:34 +0800
From:   Winston Wen <wentao@...ontech.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Steve French <smfrench@...il.com>,
        CIFS <linux-cifs@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        linux-modules@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the cifs tree

On Thu, 20 Jul 2023 11:00:21 +1000
Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
> 
> On Wed, 19 Jul 2023 19:47:42 -0500 Steve French <smfrench@...il.com>
> wrote:
> >
> > Winston had an updated version of the patch - just replaced it with
> > his updated one which does a cast to (char *)
> > 
> >           ses->local_nls = load_nls((char
> > *)ctx->local_nls->charset);
> > 
> > But as he noted in an earlier email thread:
> > > Perhaps I should make a change to load_nls() to take a const char
> > > * instead of char *? If this make sense, I'll do it soon.  
> > 
> > which is probably cleaner
> 
> s/probably/definitely/  ;-)
> 

haha yes!

I'll make a small patch for this in the next cycle.

-- 
Thanks,
Winston