linux-kernel - Re: [PATCH v2 8/9] mm/page_io: convert count_swpout_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a989179a-102a-d07d-aa80-0ff45d21a74a@huawei.com>
Date:   Thu, 20 Jul 2023 17:31:48 +0800
From:   "zhangpeng (AS)" <zhangpeng362@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        <sidhartha.kumar@...cle.com>, <akpm@...ux-foundation.org>,
        <wangkefeng.wang@...wei.com>, <sunnanyong@...wei.com>
Subject: Re: [PATCH v2 8/9] mm/page_io: convert count_swpout_vm_event() to
 take in a folio

On 2023/7/19 22:24, Matthew Wilcox wrote:

> On Wed, Jul 19, 2023 at 05:58:47PM +0800, Peng Zhang wrote:
>> -static inline void count_swpout_vm_event(struct page *page)
>> +static inline void count_swpout_vm_event(struct folio *folio)
>>   {
>>   #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> -	if (unlikely(PageTransHuge(page)))
>> +	if (unlikely(folio_test_pmd_mappable(folio)))
>>   		count_vm_event(THP_SWPOUT);
>>   #endif
> As I said in my earlier response, you don't need the ifdefs.  Check
> the definition of folio_test_pmd_mappable.

Sorry I forgot to delete the ifdefs. I'll fix it in a v3.
Thanks.

-- 
Best Regards,
Peng